Heine

  • home
  • drupal
  • drupal core commits
  • about
Home › Drupal Core Commits

Commit 397156 by dries

- Patch #850152 by kiamlaluno: use 'elseif' in place of 'else if'.

--- <a href="http://drupalcode.org/viewvc/drupal/drupal/includes/bootstrap.inc" title="http://drupalcode.org/viewvc/drupal/drupal/includes/bootstrap.inc" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/includes/bootstrap.inc</a>  2010/07/21 00:26:21     1.412
+++ <a href="http://drupalcode.org/viewvc/drupal/drupal/includes/bootstrap.inc" title="http://drupalcode.org/viewvc/drupal/drupal/includes/bootstrap.inc" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/includes/bootstrap.inc</a>  2010/07/24 17:28:25     1.413
@@ -2181,7 +2181,7 @@
       if (!isset($value['prefix'])) {
         $current_prefix = '';
       }
-      else if (is_array($value['prefix'])) {
+      elseif (is_array($value['prefix'])) {
         $current_prefix = $value['prefix']['default'];
       }
       else {

--- <a href="http://drupalcode.org/viewvc/drupal/drupal/includes/common.inc" title="http://drupalcode.org/viewvc/drupal/drupal/includes/common.inc" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/includes/common.inc</a>   2010/07/16 02:37:05     1.1192
+++ <a href="http://drupalcode.org/viewvc/drupal/drupal/includes/common.inc" title="http://drupalcode.org/viewvc/drupal/drupal/includes/common.inc" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/includes/common.inc</a>   2010/07/24 17:28:25     1.1193
@@ -5825,7 +5825,7 @@
   if (!is_null($table) && isset($schema[$table])) {
     return $schema[$table];
   }
-  else if (!empty($schema)) {
+  elseif (!empty($schema)) {
     return $schema;
   }
   return array();

--- <a href="http://drupalcode.org/viewvc/drupal/drupal/includes/database/database.inc" title="http://drupalcode.org/viewvc/drupal/drupal/includes/database/database.inc" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/includes/database/database.inc</a>  2010/07/19 13:23:21     1.128
+++ <a href="http://drupalcode.org/viewvc/drupal/drupal/includes/database/database.inc" title="http://drupalcode.org/viewvc/drupal/drupal/includes/database/database.inc" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/includes/database/database.inc</a>  2010/07/24 17:28:25     1.129
@@ -1341,7 +1341,7 @@
             'default' => '',
           );
         }
-        else if (!is_array($database_info[$index][$target]['prefix'])) {
+        elseif (!is_array($database_info[$index][$target]['prefix'])) {
           // Transform the flat form into an array form.
           $database_info[$index][$target]['prefix'] = array(
             'default' => $database_info[$index][$target]['prefix'],

--- <a href="http://drupalcode.org/viewvc/drupal/drupal/includes/path.inc" title="http://drupalcode.org/viewvc/drupal/drupal/includes/path.inc" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/includes/path.inc</a> 2010/07/19 22:12:14     1.66
+++ <a href="http://drupalcode.org/viewvc/drupal/drupal/includes/path.inc" title="http://drupalcode.org/viewvc/drupal/drupal/includes/path.inc" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/includes/path.inc</a> 2010/07/24 17:28:25     1.67
@@ -112,7 +112,7 @@
         return FALSE;
       }
       // For system paths which were not cached, query aliases individually.
-      else if (!isset($cache['no_aliases'][$path_language][$path])) {
+      elseif (!isset($cache['no_aliases'][$path_language][$path])) {
         // Get the most fitting result falling back with alias without language
         $alias = db_query("SELECT alias FROM {url_alias} WHERE source = :source AND language IN (:language, :language_none) ORDER BY language DESC, pid DESC", array(
           ':source' => $path,

--- <a href="http://drupalcode.org/viewvc/drupal/drupal/includes/utility.inc" title="http://drupalcode.org/viewvc/drupal/drupal/includes/utility.inc" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/includes/utility.inc</a>        2010/06/28 02:05:47     1.1
+++ <a href="http://drupalcode.org/viewvc/drupal/drupal/includes/utility.inc" title="http://drupalcode.org/viewvc/drupal/drupal/includes/utility.inc" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/includes/utility.inc</a>        2010/07/24 17:28:25     1.2
@@ -1,5 +1,5 @@
 <?php
-// $Id$
+// $Id: utility.inc,v 1.1 2010/06/28 02:05:47 webchick Exp $
 
 /**
  * @file
@@ -31,10 +31,10 @@
       $output .= ')';
     }
   }
-  else if (is_bool($var)) {
+  elseif (is_bool($var)) {
     $output = $var ? 'TRUE' : 'FALSE';
   }
-  else if (is_string($var)) {
+  elseif (is_string($var)) {
     $line_safe_var = str_replace("\n", '\n', $var);
     if (strpos($var, "\n") !== FALSE || strpos($var, "'") !== FALSE) {
       // If the string contains a line break or a single quote, use the

--- <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/blog/blog.module" title="http://drupalcode.org/viewvc/drupal/drupal/modules/blog/blog.module" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/blog/blog.module</a>    2010/05/29 07:53:44     1.356
+++ <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/blog/blog.module" title="http://drupalcode.org/viewvc/drupal/drupal/modules/blog/blog.module" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/blog/blog.module</a>    2010/07/24 17:28:25     1.357
@@ -151,7 +151,7 @@
     }
   }
   // Provide a helper action link to the author on the 'blog/%' page.
-  else if ($root_path == 'blog/%' && $router_item['page_arguments'][0]->uid == $user->uid) {
+  elseif ($root_path == 'blog/%' && $router_item['page_arguments'][0]->uid == $user->uid) {
     $data['actions']['output']['blog'] = array(
       '#theme' => 'menu_local_action',
     );

--- <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/comment/comment.admin.inc" title="http://drupalcode.org/viewvc/drupal/drupal/modules/comment/comment.admin.inc" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/comment/comment.admin...</a>  2010/06/25 21:24:35     1.47
+++ <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/comment/comment.admin.inc" title="http://drupalcode.org/viewvc/drupal/drupal/modules/comment/comment.admin.inc" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/comment/comment.admin...</a>  2010/07/24 17:28:25     1.48
@@ -168,7 +168,7 @@
       if ($operation == 'unpublish') {
         $comment->status = COMMENT_NOT_PUBLISHED;
       }
-      else if ($operation == 'publish') {
+      elseif ($operation == 'publish') {
         $comment->status = COMMENT_PUBLISHED;
       }
       comment_save($comment);

--- <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/contextual/contextual.module" title="http://drupalcode.org/viewvc/drupal/drupal/modules/contextual/contextual.module" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/contextual/contextual...</a>    2010/06/13 05:36:58     1.6
+++ <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/contextual/contextual.module" title="http://drupalcode.org/viewvc/drupal/drupal/modules/contextual/contextual.module" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/contextual/contextual...</a>    2010/07/24 17:28:25     1.7
@@ -78,7 +78,7 @@
     $keys = array_keys($hooks[$hook]['variables']);
     $key = $keys[0];
   }
-  else if (!empty($hooks[$hook]['render element'])) {
+  elseif (!empty($hooks[$hook]['render element'])) {
     $key = $hooks[$hook]['render element'];
   }
   if (!empty($key) && isset($variables[$key])) {

--- <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/forum/forum.module" title="http://drupalcode.org/viewvc/drupal/drupal/modules/forum/forum.module" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/forum/forum.module</a>      2010/06/20 23:55:08     1.567
+++ <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/forum/forum.module" title="http://drupalcode.org/viewvc/drupal/drupal/modules/forum/forum.module" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/forum/forum.module</a>      2010/07/24 17:28:25     1.568
@@ -761,7 +761,7 @@
     }
   }
   // If $tid is 0, create an empty object to hold the child terms.
-  else if ($tid === 0) {
+  elseif ($tid === 0) {
     $forum_term = (object) array(
       'tid' => 0,
     );

--- <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/overlay/overlay.module" title="http://drupalcode.org/viewvc/drupal/drupal/modules/overlay/overlay.module" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/overlay/overlay.module</a>  2010/07/17 02:12:36     1.24
+++ <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/overlay/overlay.module" title="http://drupalcode.org/viewvc/drupal/drupal/modules/overlay/overlay.module" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/overlay/overlay.module</a>  2010/07/24 17:28:26     1.25
@@ -92,7 +92,7 @@
       unset($_GET['render']);
     }
     // Do not enable the overlay if we already are on an admin page.
-    else if (!path_is_admin($current_path)) {
+    elseif (!path_is_admin($current_path)) {
       // Otherwise add overlay parent code and our behavior.
       overlay_set_mode('parent');
     }

--- <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/simpletest.pages.inc" title="http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/simpletest.pages.inc" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/simpletest...</a>      2010/05/19 19:22:24     1.30
+++ <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/simpletest.pages.inc" title="http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/simpletest.pages.inc" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/simpletest...</a>      2010/07/24 17:28:26     1.31
@@ -344,7 +344,7 @@
   if ($form_state['values']['filter'] == 'all') {
     $classes = array_merge($pass, $fail);
   }
-  else if ($form_state['values']['filter'] == 'pass') {
+  elseif ($form_state['values']['filter'] == 'pass') {
     $classes = $pass;
   }
   else {

--- <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/tests/file_test.module" title="http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/tests/file_test.module" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/tests/file...</a>  2010/06/26 19:55:47     1.23
+++ <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/tests/file_test.module" title="http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/tests/file_test.module" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/tests/file...</a>  2010/07/24 17:28:26     1.24
@@ -113,7 +113,7 @@
   if ($form_state['values']['allow_all_extensions']) {
     $validators['file_validate_extensions'] = array();
   }
-  else if (!empty($form_state['values']['extensions'])) {
+  elseif (!empty($form_state['values']['extensions'])) {
     $validators['file_validate_extensions'] = array($form_state['values']['extensions']);
   }
 

--- <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/tests/system_test.module" title="http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/tests/system_test.module" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/tests/syst...</a>      2010/06/28 20:27:34     1.30
+++ <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/tests/system_test.module" title="http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/tests/system_test.module" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/simpletest/tests/syst...</a>      2010/07/24 17:28:26     1.31
@@ -263,11 +263,11 @@
     $page['footer'] = drupal_set_page_content();
     $page['footer']['main']['#markup'] = '<div id="system-test-content">' . $page['footer']['main']['#markup'] . '</div>';
   }
-  else if ($menu_item['path'] == 'system-test/main-content-fallback') {
+  elseif ($menu_item['path'] == 'system-test/main-content-fallback') {
     drupal_set_page_content();
     $main_content_display = FALSE;
   }
-  else if ($menu_item['path'] == 'system-test/main-content-duplication') {
+  elseif ($menu_item['path'] == 'system-test/main-content-duplication') {
     drupal_set_page_content();
   }
 }

--- <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/system/system.tar.inc" title="http://drupalcode.org/viewvc/drupal/drupal/modules/system/system.tar.inc" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/system/system.tar.inc</a>     2010/07/22 23:54:32     1.6
+++ <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/system/system.tar.inc" title="http://drupalcode.org/viewvc/drupal/drupal/modules/system/system.tar.inc" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/system/system.tar.inc</a>     2010/07/24 17:28:26     1.7
@@ -36,7 +36,7 @@
  * @author      Vincent Blavet <vincent@phpconcept.net>
  * @copyright   1997-2008 The Authors
  * @license     <a href="http://www.opensource.org/licenses/bsd-license.php" title="http://www.opensource.org/licenses/bsd-license.php" rel="nofollow">http://www.opensource.org/licenses/bsd-license.php</a> New BSD License
- * @version     CVS: $Id: system.tar.inc,v 1.5 2010/02/09 12:29:39 dries Exp $
+ * @version     CVS: $Id: system.tar.inc,v 1.6 2010/07/22 23:54:32 dries Exp $
  * @link        <a href="http://pear.php.net/package/Archive_Tar<br />
" title="http://pear.php.net/package/Archive_Tar<br />
" rel="nofollow">http://pear.php.net/package/Archive_Tar<br />
</a>  */
 
@@ -47,7 +47,7 @@
 * Creates a (compressed) Tar archive
 *
 * @author   Vincent Blavet <vincent@phpconcept.net>
-* @version  $Revision: 1.5 $
+* @version  $Revision: 1.6 $
 * @license  <a href="http://www.opensource.org/licenses/bsd-license.php" title="http://www.opensource.org/licenses/bsd-license.php" rel="nofollow">http://www.opensource.org/licenses/bsd-license.php</a> New BSD License
 * @package  Archive_Tar
 */
@@ -146,7 +146,7 @@
         if ($this->_compress) { // assert zlib or bz2 extension support
             if ($this->_compress_type == 'gz')
                 $extname = 'zlib';
-            else if ($this->_compress_type == 'bz2')
+            elseif ($this->_compress_type == 'bz2')
                 $extname = 'bz2';
 
             if (!extension_loaded($extname)) {
@@ -650,9 +650,9 @@
     {
         if ($this->_compress_type == 'gz')
             $this->_file = @gzopen($this->_tarname, "wb9");
-        else if ($this->_compress_type == 'bz2')
+        elseif ($this->_compress_type == 'bz2')
             $this->_file = @bzopen($this->_tarname, "w");
-        else if ($this->_compress_type == 'none')
+        elseif ($this->_compress_type == 'none')
             $this->_file = @fopen($this->_tarname, "wb");
         else
             $this->_error('Unknown or missing compression type ('
@@ -703,9 +703,9 @@
 
         if ($this->_compress_type == 'gz')
             $this->_file = @gzopen($v_filename, "rb");
-        else if ($this->_compress_type == 'bz2')
+        elseif ($this->_compress_type == 'bz2')
             $this->_file = @bzopen($v_filename, "r");
-        else if ($this->_compress_type == 'none')
+        elseif ($this->_compress_type == 'none')
             $this->_file = @fopen($v_filename, "rb");
         else
             $this->_error('Unknown or missing compression type ('
@@ -752,9 +752,9 @@
         if (is_resource($this->_file)) {
             if ($this->_compress_type == 'gz')
                 @gzclose($this->_file);
-            else if ($this->_compress_type == 'bz2')
+            elseif ($this->_compress_type == 'bz2')
                 @bzclose($this->_file);
-            else if ($this->_compress_type == 'none')
+            elseif ($this->_compress_type == 'none')
                 @fclose($this->_file);
             else
                 $this->_error('Unknown or missing compression type ('
@@ -801,9 +801,9 @@
           if ($p_len === null) {
               if ($this->_compress_type == 'gz')
                   @gzputs($this->_file, $p_binary_data);
-              else if ($this->_compress_type == 'bz2')
+              elseif ($this->_compress_type == 'bz2')
                   @bzwrite($this->_file, $p_binary_data);
-              else if ($this->_compress_type == 'none')
+              elseif ($this->_compress_type == 'none')
                   @fputs($this->_file, $p_binary_data);
               else
                   $this->_error('Unknown or missing compression type ('
@@ -811,9 +811,9 @@
           } else {
               if ($this->_compress_type == 'gz')
                   @gzputs($this->_file, $p_binary_data, $p_len);
-              else if ($this->_compress_type == 'bz2')
+              elseif ($this->_compress_type == 'bz2')
                   @bzwrite($this->_file, $p_binary_data, $p_len);
-              else if ($this->_compress_type == 'none')
+              elseif ($this->_compress_type == 'none')
                   @fputs($this->_file, $p_binary_data, $p_len);
               else
                   $this->_error('Unknown or missing compression type ('
@@ -832,9 +832,9 @@
       if (is_resource($this->_file)) {
           if ($this->_compress_type == 'gz')
               $v_block = @gzread($this->_file, 512);
-          else if ($this->_compress_type == 'bz2')
+          elseif ($this->_compress_type == 'bz2')
               $v_block = @bzread($this->_file, 512);
-          else if ($this->_compress_type == 'none')
+          elseif ($this->_compress_type == 'none')
               $v_block = @fread($this->_file, 512);
           else
               $this->_error('Unknown or missing compression type ('
@@ -854,11 +854,11 @@
           if ($this->_compress_type == 'gz') {
               @gzseek($this->_file, gztell($this->_file)+($p_len*512));
           }
-          else if ($this->_compress_type == 'bz2') {
+          elseif ($this->_compress_type == 'bz2') {
               // ----- Replace missing bztell() and bzseek()
               for ($i=0; $i<$p_len; $i++)
                   $this->_readBlock();
-          } else if ($this->_compress_type == 'none')
+          } elseif ($this->_compress_type == 'none')
               @fseek($this->_file, ftell($this->_file)+($p_len*512));
           else
               $this->_error('Unknown or missing compression type ('
@@ -1834,11 +1834,11 @@
                     // ----- Ignore this directory
                     // Should be the first $i=0, but no check is done
                 }
-                else if ($v_list[$i] == "..") {
+                elseif ($v_list[$i] == "..") {
                     // ----- Ignore it and ignore the $i-1
                     $i--;
                 }
-                else if (   ($v_list[$i] == '')
+                elseif (   ($v_list[$i] == '')
                                         && ($i!=(sizeof($v_list)-1))
                                                 && ($i!=0)) {
                     // ----- Ignore only the double '//' in path,

--- <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/user/user.module" title="http://drupalcode.org/viewvc/drupal/drupal/modules/user/user.module" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/user/user.module</a>    2010/07/24 16:53:28     1.1184
+++ <a href="http://drupalcode.org/viewvc/drupal/drupal/modules/user/user.module" title="http://drupalcode.org/viewvc/drupal/drupal/modules/user/user.module" rel="nofollow">http://drupalcode.org/viewvc/drupal/drupal/modules/user/user.module</a>    2010/07/24 17:28:27     1.1185
@@ -3201,7 +3201,7 @@
       $permission_alias = $query->join('role_permission', 'p', $user_role_alias . '.rid = %alias.rid');
       $query->condition($permission_alias . '.permission', $value);
     }
-    else if ($key == 'role') {
+    elseif ($key == 'role') {
       $user_roles_alias = $query->join('users_roles', 'ur', '%alias.uid = u.uid');
       $query->condition($user_role_alias . '.rid' , $value);
     }

No votes yet
  • Drupal Core
  • Download patch

Recent posts

  • Aan: prorail - Hekwerk langs tunnel onvoldoende - kinderen op spoordijk
  • Unserializing user-supplied data, a bad idea
  • Planet Drupal past and current
  • Help! - Cannot access a global variable.
  • Why is my module's update hook not listed on update.php's selection form?
more

Security reviews

  • Afraid custom code makes your site vulnerable?
  • You don't really trust that module you just downloaded from Drupal.org?

Sleep better after a security review.

Tags

Captcha CSRF Drupal embed Input Format modx OpenID Performance Planet Drupal rants Security Varnish
more tags
  • home
  • drupal
  • drupal core commits
  • about

Copyright © 2010 by Heine Deelstra. All rights reserved.